open-tl866 icon indicating copy to clipboard operation
open-tl866 copied to clipboard

Firmware reliability issue?

Open JohnDMcMaster opened this issue 2 years ago • 1 comments

A few times we've observed what looks like some sort of reliability issue. Ex: yesterday tried to set VPP and it wasn't working. Re-init device and starts working again. Think there is some low level issue that might be causing memory corruption

JohnDMcMaster avatar Nov 02 '22 04:11 JohnDMcMaster

Found something interesting in comlib:com_readline()

                printf(out_buf);

This has several red flags:

  • printf()'ing a format string supplied by an external user. Ex: typing %s into the terminal may cause weird results
  • Newline terminal is dicy, but probably ok

JohnDMcMaster avatar Nov 02 '22 04:11 JohnDMcMaster