Echarts v6.0.0 Released, any plan to upgrade echarts4r?

[bianchenhao]

[rdatasculptor]

I am very interested as well. Any plans @munoztd0, @JohnCoene? Do you need any specific help for that? Maybe I can do my part.

Especially the new matrix coordinate system seems really interesting for making complete dashboards.

[JohnCoene]

@rdatasculptor thank you. I'd be super keen to have that in but my wife and I have just had our first child so I really don't have much time at all work to work on this.

You can open a PR, I'd be more than happy to help where I can, feel free to ask me or @munoztd0!

[rdatasculptor]

@JohnCoene congratulations with your first one!! Give it all the time of the world:)

@munoztd0 I don't know (yet) where to start, but maybe I can assist you with anything regarding this upgrade. Any plans yet?

[munoztd0]

@rdatasculptor , well the first steps would be to update the js files within inst, here you can see a an example of bumping versions: https://github.com/JohnCoene/echarts4r/commit/a863fcc553a4b6f0facdce4db0317c4b575029f1

If you do a PR with the new echarts version of these files, I could start running test, documentations and such and we would have a demo branch for it.

I am moving away to Japan so I don't have a lot of free time but I would gladly help when I can

[jacciz]

I'd like to help with updating to 6.0.0. I've just started to use echarts and love how clean the plots look! I do have the updated js files and did fix some warnings with {dplyr}. I'm creating a PR.

[jacciz]

Closing my PR and currently working off of @patrekieta PR.

[jacciz]

We are working on a PR. Can I get some input on improving unit testing coverage? I've made some changes already. I'm considering testServer to test the proxy functionality. I may have identified some bugs as well.

[munoztd0]

I think it's a good idea, I want to take a look at it but there is still some issue to check before:

** testing if installed package can be loaded from temporary location
Error: Error: package or namespace load failed for 'echarts4r' in namespaceExport(ns, exports):
 undefined exports: e_format_matrix_axis, e_heatmap_matrix, e_pie_matrix, e_scatter_matrix

[jacciz]

I believe those errors are from Patrick's work on adding the new coordinate matrix system - which he may be stuck on? I haven't pushed the new testServer stuff yet, but will within the next couple of days.

[patrekieta]

Sorry for the delayed response. It looks like during one of the merges that we did, an earlier commit related to the matrix functions was overwritten. I have rebuilt the commit and updated the documentation. If you pull from the branch now, it should work correctly (I hope). If it still isn't working, let me know and I'll try to fix it quickly.

As a side note, I have been pretty busy between work and planning/packing for my upcoming vacation. I'll be in Japan for a few weeks this holiday season so I will try to work on code but progress may be slow.