John Coene

Results 202 comments of John Coene

Yes, I haven't found the time to just yet; hopefully sometime this year.

Yes, I meant to add tests but never found the time. This would be more than welcome! Indeed, you would use testthat as you do, you cannot test the graphical...

Sure, you can it a few context/files at a time if you feel like it.

I think a key thing to test is the data structure produced by echarts4r for each "geom," `expect_s3_class` only test that the object returned is indeed of the class but...

Sorry, I'm not sure what you mean by "custom," do you mean the use of the `levels` argument?

Ah, boxes are not actual {htmlwidgets}, I thought it was smart to bypass all of this for these... perhaps it was not. I will have to think of a solution....

You're not doing anything wrong but I don't see anything wrong with echarts4r itself: it looks like it might be in ECharts.js itself. I'll try to look into it in...

That'd be great indeed but is a lot of work, I have to see if this is feasible and how.