John Albin Wilkins comments

Results 117 comments of


                                            John Albin Wilkins

px must match the units of the grid width

I just opened a feature request which might do what you want. #82 I won't have time to work on it for free any time soon.

px must match the units of the grid width

Actually, we should add this rationale to some docs.

Mocked fetch response cannot dynamically change HTTP status, status text or headers

> your code only mocks fetch, but Angular uses XHR, so it's important to note that it's not compatible with Angular apps. Fair enough. But if an app needs XHR...

Encourage .yaml instead of .yml

:+1:

A typescript package that supports both commonjs and esmodule should generate `.d.ts` and `.d.cts` type files, now only `.d.ts`

Specifically, the [TypeScript docs](https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing) say: > It’s important to note that the **CommonJS entrypoint and the ES module entrypoint each needs its own declaration file, even if the contents are...

support include function

I've added this to the implementation notes on the wiki. https://github.com/twigjs/twig.js/wiki/Implementation-Notes

support include function

@willrowe I think you are misreading the docs. The `include` _tag_ is listed as supported. I added the note about the `include` function that says: > `include`: Throws error: "include...

Upgrade starters to App Router

This PR also fixes #749

Add methods to support App Router

~~Blocked by #740~~ And… unblocked now.

Update types.ts: add default field 'promote' to DrupalNode

I just refactored the type definitions so they aren't in one giant file and broke this PR. Sorry!