John Fernandez

Results 66 comments of John Fernandez

So it sounds like it fixes issues for joysticks with near the max number of buttons, so I think we just need someone to test the converse: that joysticks with...

Hey, I'm just converting this to draft until we figure out if we want to make the string generation dynamic or not, so that no one merges it by accident....

I don't think we'd be able to upgrade to c++ 20 just for this. We do have some c++ 17 features added via small libraries, but we're targeted to c++11...

Just a quick note. I believe that this is probably a lot more reasonable to do with @BMagnu's LUA AI feature. It would be hard to come up with hard-coded...

I did not see any odd text behavior when I tested this patch.

Have you tried running in windowed mode (or fullscreen window)? I have seen some minor issues in regular fullscreen before. There's probably some small mistakes in how we use SDL

And then I hit the approve button by accident.

Sorry for the slow reply, I'm always missing updates on github. I managed to get this result just by playing around with some semi-nonsense semver strings: ![Screenshot 2024-02-10 172250](https://github.com/scp-fs2open/fs2open.github.com/assets/12529946/b823c956-961e-4ebc-a435-1e04a2f39c39) What...

I hate our sound code, but I think I have tracked this down. `Channel.sid` is not the index into `Sounds` it is the index into `sound_buffer` I cannot test right...

Ok. Not sure how this code worked in the first placed. Using the id the code was using before should not work properly, but I tried replacing it and now...