John Nagle

Results 137 comments of John Nagle

Turns out that the macro stores the canonical full path of the embedded file in the executable, for use in debug builds. This is wrong when source host != target...

It's back, post-arcanization. If I got an error return for this it would be handled. ``` Panic wgpu error: Validation Error Caused by: In Device::create_bind_group note: label = `GpuCuller rend3_routine::pbr::material::PbrMaterial...

Looking at frame variation. Frame 5274 took 78ms. No one thing dominates. - SwapChain::present took about 10ms, about 10x the usual time. - Tonemapping also took about 10ms, mostly in...

Tracy performance trace files can be downloaded from [https://animats.com/sl/misc/](https://animats.com/sl/misc) The one above is [vallone2.trace.tracy](http://animats.com/sl/misc/traces/vallone2.trace.tracy). Note, 25MB. This can be read with [Tracy Profiler 0.10](https://github.com/wolfpld/tracy/releases). That gives detailed access to the...

Places that look slow in the slow example above: - SwapChain::present took 8ms in the slow frame, well under 1ms in the fast frame. - ToneMapping took 8ms in the...

Possible performance bottlenecks,with GPU culling removed: Texture create view - seems that the loader threads can stall the render thread for a while at a texture create. ![createviewstallcombined](https://github.com/BVE-Reborn/rend3/assets/942608/20dca116-6c04-433a-bfb0-4e93e67e023d) Mesh create...

Looking at https://github.com/gfx-rs/wgpu/blob/d4f30638b749f269feeb654d7880a7d845a2fff1/wgpu-core/src/device/global.rs#L785 Notes - That function acquires three locks, non-nested. One of those locks can be held for too long, but can't tell which one./ - The "loop" does...

Tried new Rend3, rev "e1cfe1b". Modified code to detect error returns from mesh, texture creation. Just panics for now. Seems to be basically working. Many log entries of the form:...

Subscript out of range error: ``` 06:24:13 [ERROR] Asset request (AssetRequestTimestamped { request: AssetRequest { content: Mesh(MeshRequest { uuid: 7bdbe80d-6d20-65a2-56fe-9d9d1994e78a }), capability: "http://asset-cdn.glb.agni.lindenlab.com" }, timestamp: Instant { tv_sec: 1378365, tv_nsec:...