imagehash icon indicating copy to clipboard operation
imagehash copied to clipboard

Published 20 hours ago • verified publisher icon JohannesBuchner

Remove outdated Python2 code

Open Rotzbua opened this issue 1 year ago • 3 comments

Change

  • Remove outdated Python2 code
  • Remove six package

Rotzbua avatar Oct 24 '23 16:10 Rotzbua

Coverage Status

coverage: 87.805% (-0.04%) from 87.847% when pulling 1849bc46ca9e8c5fc0634aabe2db4fdd7fc75c97 on Rotzbua:remove_python2_code into 5e9ef5d3cdd822ae1a325b1eaf0bbe4eda4090cd on JohannesBuchner:master.

coveralls avatar Oct 24 '23 16:10 coveralls

imagehash had Python 2 support much longer than other packages, and it helped a number of users stuck on ancient systems that do not receive updates. I had PRs from several people over the years trying to remove it and calling it outdated.

Unfortunately it has basically become impossible to run CI against such old versions now. So I think we may have to go with the times and say goodbye to Python 2 support at this point and recommend the affected users to use old versions.

JohannesBuchner avatar Oct 24 '23 18:10 JohannesBuchner

Hi @Rotzbua, sorry for picking this up so late. I'd be happy to merge this, but I see that there is a conflict. Can you please fix it?

JohannesBuchner avatar Sep 10 '24 06:09 JohannesBuchner