BXA icon indicating copy to clipboard operation
BXA copied to clipboard

Recover Sherpa analysis status when fitting PCA backgrounds

Open ruizca opened this issue 2 years ago • 1 comments

This pull request address issue #34

ruizca avatar Mar 17 '22 12:03 ruizca

This looks good. Nice and clean code.

Did you test it?

I have to set up Github actions first, so that this can be tested (since the last BXA release, travis-CI removed their permanently-free open source tier).

But I wonder if the alternative approach you suggested, may not be better, because it requires less code to maintain. By that I mean documenting the behaviour so that users are aware. That would be editing this document: doc/pca-background-models.rst

JohannesBuchner avatar Mar 17 '22 16:03 JohannesBuchner