an error in gof.py

[ellot]

I use BXA in pyxspec. In some cases, there are nan values in lowmodel_parts. So the assert error is reported in line 85 of gof.py. I find some values of kplusones equal 0 (line 78, 79).

[JohannesBuchner]

Hmm, doesn't that mean data was <0 somewhere? Are you using binning on non-count data somehow?

[ellot]

Yes, in few cases, the net counts (subtracting background) is <0.

[JohannesBuchner]

That code (binning function) is only supposed to be run on count data, not subtracted data.

[JohannesBuchner]

Probably the exception should be raised earlier, in the binning function.