Johan Larsson
Johan Larsson
Thanks for reporting! And what a beautiful issue! I don't know this stuff well and it will be somewhat tricky if we don't have a good way to repro but...
I wrote a PR with some cargo culting. If you have time you can review if it makes any sense. Chances are it just pushes the problem to crop up...
Which version do you prefer? Also about speed it is probably plenty fast enough as it is only run once at app startup.
I would expect the added startup time to be in the microseconds. We can run some benechmarks and optimize later if needed. Things can probably be made lazy there.
Ah, nice, very valid point. We should refactor to that so that we can write an UI-test that uses the cultures your client had. That way we can be sure...
https://www.nuget.org/packages/Gu.Localization/6.4.3 Takes 15 minutes or so for nuget to index it.
If you decide to try writing UI-tests for it I think it is best to make a small separate app for this scenario that we use in the tests.
Unit test only is fine. I don't have anything special in mind other than that it is nice knowing that everything works together when run in an app. I can...
We have a gitter room if you feel like chatting: https://gitter.im/JohanLarsson/Gu.Localization
Ran a quick [benchmark](https://github.com/GuOrg/Gu.Localization/blob/master/Gu.Localization.Benchmarks/CultureBenchmark.cs) for fun. Confirmed microseconds. ``` | Method | Mean | Error | StdDev | Gen 0 | Allocated | |------------------------------ |---------:|---------:|---------:|--------:|----------:| | CreateNeutralCultureRegionMap | 220.7 us...