Hari Hara Naveen S
Hari Hara Naveen S
Also, requesting review on if the CI failures in the tsan suite are false positives
Changes requested my @MisterDA have been pushed, requested review and merge.
Timing it with the patch (changes to asm) ```sh $ time ./boot/ocamlrun ./ocamlopt -nostdlib -I ./stdlib -I otherlibs/dynlink -g -strict-sequence -principal -absname -w +a-4-9-40-41-42-44-45-48 -warn-error +a -bin-annot -strict-formats -I typing...
Tried out `hyperfine` with `./ocamlopt.opt`, PFA the results ```sh $ hyperfine "./ocaml/ocamlopt.opt -nostdlib -I ./ocaml/stdlib -I ocaml/otherlibs/dynlink -g -strict-sequence -principal -absname -w +a-4-9-40-41-42-44-45-48 -warn-error +a -bin-annot -strict-formats -I ocaml/typing -I...
> Looking good. Is this with the changes in assembly? Yes it was a comparison between changing `amd64.S` calls from `__tsan_*` to `caml_tsan`, and the test was done locally on...
Replacing __tsan* with caml_tsan ```c diff --git a/asmcomp/thread_sanitizer.ml b/asmcomp/thread_sanitizer.ml index 685bbd7f98..d9d5d0ad0e 100644 --- a/asmcomp/thread_sanitizer.ml +++ b/asmcomp/thread_sanitizer.ml @@ -69,13 +69,13 @@ let wrap_entry_exit expr = let call_entry = Cmm_helpers.return_unit dbg_none (Cop...
@OlivierNicole I have also pushed the `.S` changes If it looks good we can merge it in the same PR If more thorough changes are required I will rollback the...