react-jupyter-notebook icon indicating copy to clipboard operation
react-jupyter-notebook copied to clipboard

Published 20 hours ago • verified publisher icon Joeyonng

react & react-dom should be declared in peerDependencies section

Open chenxinyanc opened this issue 2 years ago • 0 comments

We are currently using this package on react 18 / react-dom 18, but our package manager decides to install a duplicate react 17 / react-dom 17 because the version spec in the package.json has restricted the react major version to be 17

https://github.com/Joeyonng/react-jupyter-notebook/blob/deddebcce78180818ba0d8479edf09f86f42f9ed/package.json#L34-35

Could you please

  1. Loosen the react version spec from ^17.0.1 to >=17.0.1
  2. Declare dependency to react / react-dom in peerDependencies section?

chenxinyanc avatar Nov 23 '22 05:11 chenxinyanc