react-native-text-recognition icon indicating copy to clipboard operation
react-native-text-recognition copied to clipboard

Published 20 hours ago • verified publisher icon JoeyEamigh

requiresMainQueueSetup

Open nicolasdevienne opened this issue 3 years ago • 5 comments
trafficstars

Hi @JoeyEamigh! At first launch of the iOS app, a warning appears in the console : Module TextRecognition requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of. It works but maybe you can correct this warning?

nicolasdevienne avatar Jul 29 '22 20:07 nicolasdevienne

TextRecognition.swift

@objc(TextRecognition)
class TextRecognition: NSObject {

Add the line below + @objc static func requiresMainQueueSetup() -> Bool { return true }

  @objc(recognize:withOptions:withResolver:withRejecter:)

Works fine in my setting.

ElicaInc avatar Mar 12 '23 06:03 ElicaInc

Thx @ElicaInc! @JoeyEamigh is it OK for you to create a PR for this?

nicolasdevienne avatar Aug 23 '23 18:08 nicolasdevienne

Have at it! I don't really use this library anymore so I don't update it much but I would be happy to merge PRs!

JoeyEamigh avatar Aug 23 '23 18:08 JoeyEamigh

It's up to @JoeyEamigh!

ElicaInc avatar Aug 24 '23 00:08 ElicaInc

Done! https://github.com/JoeyEamigh/react-native-text-recognition/pull/14/files

nicolasdevienne avatar Aug 29 '23 13:08 nicolasdevienne