Joel Speed
Joel Speed
> Is this behavior expected? Shouldn't controller-gen consider this marker only for the latest version? The latest is hard to define, since technically the version string can be anything and...
Not a maintainer here, but I do API reviews. In general it is recommended not to recycle structs between types unless they are closely related. For example, imagine sharing a...
/test all Need to work out how to test this, but want to see what the existing tests do with this so I can fix any failures introduced
/assign @alvaroaleman
> > @JoelSpeed Can we get rid of the vendor folder? It's probably on my side but the performance of the file tab is pretty bad with 1700 files. >...
@jakobmoellerdev Reached out to me last week and sent me a patch that we think resolves a number of the comments here. @jakobmoellerdev Anything the reviewers need to know about...
@erikgb I'm currently waiting on a second round of review from those who previously reviewed. @jakobmoellerdev kindly continued the work and we pushed his updates to my branch, but haven't...
> How fundamentally might this PR change with the rebase that is necessary for 1.30? Great question. I know there's been a massive rewrite of the gengo stuff, I have...
I likely won't have time until next friday to take that on, but if you want to have a go @jakobmoellerdev I can force push whatever you come up with...