google-images-download icon indicating copy to clipboard operation
google-images-download copied to clipboard

Made patch-1 more flexible

Open Joeclinton1 opened this issue 4 years ago • 2 comments

Patch-1 relies to much on the google image format always staying the same this version is much more flexible, and won't break every few months.

Joeclinton1 avatar Sep 06 '20 14:09 Joeclinton1

I tried your branch and it doesnt work on my ubuntu 20.04. Master branch works. I got stuff like this:

["https://encrypted-tbn0.gstatic.com/images?q\u003dtbn%3AANd9GcTJhZKj73y9awAVsXsadx3nLgK7vJt0yfDvVQ\u0026usqp\u003dCAU",188,268]\n,["https://cdn.the-scientist.com/assets/articleNo/66400/aImg/33464/cat-paw-l.png",840,1200]\n,null,0,"rgb(232,232,226)",null,false,{"2001":[null,null,null,9,0,21,9,null,null,null,[]\n]\n,"2003":[null,"fTMj9aL3mYlkuM","https://www.the-scientist.com/news-opinion/chinas-first-cloned-kitten--garlic-66400","China's First Cloned Kitten, Garlic | The Scientist Magazine\xc2\xae",null,null,null,null,null,false,null,null,"The Scientist Magazine",null,null,null,null,null,null,null,null,null,null,null,false,{"26":[null,2]\n}]\n,"2008":[null,"China's First Cloned Kitten, Garlic ..."]\n,"183836587":["the-scientist.com"]

Could not open URL. Please check your internet connection and/or ssl settings If you are using proxy, make sure your proxy settings is configured correctly

lyris85 avatar Sep 17 '20 14:09 lyris85

@lyris85 Hi, sorry I just submitted the pull request to keep things organised but this is actually unfinished. The idea behind this is that it finds the url's one by one by using a regex to find strings which include the basic stuff required for something to be a url. This is so much more flexible, and can't break.

Once I finish it, i'll ask some people to test it and if it's better than the original, i'll merge it to the master.

Joeclinton1 avatar Sep 17 '20 14:09 Joeclinton1