Joé Dupuis

Results 18 comments of Joé Dupuis

I had discussed it with a few folks internally already and it was on my to-do list for after I was done supporting the existing feature set of the adapter....

> until a new version of the gem is not published. I'll be surprised if we ever see a new release. The RubyGems release has been broken on since February...

No worries! I was originally under the impression that you worked with the maintainer and could have nudge them to cut a release. Sorry if my message was overly salty,...

@byroot I rebased to fix the failing tests. Looks like [there is still a flake](https://buildkite.com/rails/rails/builds/107007#018f64d9-8d94-48fe-b63b-3cab9951fa63) even if Github is showing that the test suite passed. I pushed a attempt at...

@zzak Yup, without Rails, it would default to the old behavior before [the breaking change was introduced](https://github.com/rails/rails/pull/51483). I am hoping to add a deprecation warning at some point and remove...

@skipkayhil I was trying to catch all uses of `active_connection?` in case there was more Executor hooks after this one, but you are right, as you pointed out, the `QueryCache`...

The failing tests seem safe to ignore (unrelated). They are failing on the other `7-1-stable` builds: https://buildkite.com/rails/rails/builds?branch=7-1-stable https://buildkite.com/rails/docs-preview/builds?branch=7-1-stable

I spent an absurd amount of time trying to strict load the gem's models. :facepalm: I don't think it's worth it. I opened a PR (#375) to turn strict loading...