Joe Abraham

Results 15 comments of Joe Abraham

@aditi-pandit Can you please review?

Opened a new PR with e2e testcases, could only be merged after this PR. https://github.com/prestodb/presto/pull/21537

@karteekmurthys , @pramodsatya I have incorporated the changes, can you please resolve the comments and check if the changes are good.

@karteekmurthys @aditi-pandit Can you please have a look into the PR?

@karteekmurthys Please resolve the threads that look good.

@aditi-pandit I have created separate individual PRs for the requirement Please review the separated PRs https://github.com/facebookincubator/velox/pull/8652 https://github.com/facebookincubator/velox/pull/8651 https://github.com/facebookincubator/velox/pull/8650 https://github.com/facebookincubator/velox/pull/8647 https://github.com/facebookincubator/velox/pull/7672 @czentgr @karteekmurthys @pramodsatya

@mbasmanova It is WIP and I have a few reworks pending. I will request for re-review, once I am done. Hope that sounds good!

@mbasmanova, Can you please look into the reworks that were done?

@bikramSingh91 I am a bit confused about what needs to be added at `velox/docs/functions/presto/binary. rst`. Could you please help me understand the changes required in this file?