react-qr-reader icon indicating copy to clipboard operation
react-qr-reader copied to clipboard

Add react 18 as valid peer dependecy

Open errnesto opened this issue 2 years ago • 6 comments

This simply adds react18 and react-dom18 as valid peer dependcies so this can be used with a current react version

errnesto avatar May 16 '23 16:05 errnesto

Merging this in would be great because enabling peer-dependencies is a hacky solution and an anti-pattern. Thanks for making the changes @errnesto

platramos avatar May 25 '23 16:05 platramos

+1, please merge and send it! 🥳

vandijkstef avatar Jun 07 '23 13:06 vandijkstef

+1, would really need this! Merge and release please!

katistix avatar Jun 18 '23 06:06 katistix

+1, it would be great!

davidnoelopez avatar Jul 04 '23 23:07 davidnoelopez

Yes please merge 🙏

BenPreston avatar Jul 19 '23 16:07 BenPreston

When you're waiting for this, I published a package called @whats-tools/react-qr-reader which unlocks react v18 at peer dependencies. => v3.0.0-alpha.3

I've tested for a while in one particular react v18 project using npm i --force. But the best way I passed through it without adding any problems with another packages vulnerabilities was publishing this new project.

neilor avatar Aug 14 '23 12:08 neilor