react-qr-reader icon indicating copy to clipboard operation
react-qr-reader copied to clipboard

Published 20 hours ago • verified publisher icon JodusNodus

Does it support React 17?

Open fandi-komek opened this issue 3 years ago • 9 comments

I've got issue when trying to install on local project with log:

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: [email protected] npm ERR! Found: [email protected] npm ERR! node_modules/react npm ERR! react@"^17.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"~16" from [email protected] npm ERR! node_modules/react-qr-reader npm ERR! react-qr-reader@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

fandi-komek avatar Nov 30 '21 10:11 fandi-komek

I have same error

Smartmikey avatar Dec 18 '21 22:12 Smartmikey

There is a workaround npm install JodusNodus/react-qr-reader#pull/192/head

chaitanyaarige avatar Dec 19 '21 07:12 chaitanyaarige

install with yarn solve my problems idk how, but works

joaodobread avatar Dec 25 '21 00:12 joaodobread

Any plans to fix this? Getting the same error

ChristopherHButler avatar Jan 12 '22 11:01 ChristopherHButler

The same error!

VentsislavKostadinov avatar Jan 23 '22 23:01 VentsislavKostadinov

Working on a new release to support it.

JodusNodus avatar Feb 05 '22 20:02 JodusNodus

Hi @JodusNodus! we were considering switching to a different lib because of this but we may wait if you think the new version supporting React 17 won't take too long to be released. Do you have an estimated time so we can make a decision? Thx for the great work!

amonsosanz avatar Feb 07 '22 11:02 amonsosanz

@amonsosanz We will be merging the work over at https://github.com/BlackBoxVision/react-qr-reader . So i would recommend using that until a new version is available here.

JodusNodus avatar Feb 07 '22 12:02 JodusNodus

@JodusNodus, could you please just update the react peer dependencies in 2.2.1 to support react 17 and bump the version to 2.2.2?

The new 3.0 beta version and the BlackBoxVision version have an entirely different props API and the lib doesn't seem production ready (I tried using the 3.0.0-beta-1 version and it had several issues).

2.2.1 works just fine with React 17.0.2 when installing with yarn. But my cloud hosting service (Google Cloud) is installing dependencies using NPM and gets stuck/blocked by this peer dependency conflict.

rscotten avatar Feb 25 '22 14:02 rscotten