react-qr-reader icon indicating copy to clipboard operation
react-qr-reader copied to clipboard
verified publisher icon JodusNodus

React 16.3+ compatibility: replace componentWillReceiveProps with componentDidUpdate

Open simmerer opened this issue 6 years ago • 6 comments

Replacement looks to be straightforward.

simmerer avatar Oct 24 '19 23:10 simmerer

Why was this closed?

Even if not the best approach, the fix would work and remove any warning message.

Please consider reopening and merging.

Indigo744 avatar Nov 12 '19 09:11 Indigo744

Btw. https://github.com/kybarg/react-qr-scanner works with react 16.3+

PeterTheOne avatar Jul 28 '20 13:07 PeterTheOne

Btw. https://github.com/kybarg/react-qr-scanner works with react 16.3+

But it doesn't seem to work fine on MacOs / iOS. Any news about accepting this PR?

flefloch-payps avatar Aug 19 '20 09:08 flefloch-payps

Hey guys any plans on merging this or fixing the componentWillReceiveProps deprecation warning? Seems like it still there.

iamgutz avatar Dec 14 '20 23:12 iamgutz

Hello, I also ask you to solve this problem. Thank you in advance

kadriev-ilyas avatar Feb 13 '21 20:02 kadriev-ilyas

same here

FlorianFlatscher avatar Dec 06 '21 12:12 FlorianFlatscher