skforecast icon indicating copy to clipboard operation
skforecast copied to clipboard

Question regarding Documentation: In Production

Open nkotwal93 opened this issue 2 years ago • 1 comments

https://joaquinamatrodrigo.github.io/skforecast/0.4.3/notebooks/forecaster-in-production.html

The note at the end of this page states the following: It is important to note that last_window's length must be enough to include the maximum lag used by the forecaster. For example, if the forecaster uses lags 1, 24, 48, last_window must include the last 72 values of the series.

I do not understand why would you need 72 values in the above example when your MaxLag is 48?

nkotwal93 avatar Aug 05 '22 17:08 nkotwal93

Hello @nkotwal93,

Thanks for the note. Correct, last_window's length should be the same as the maximum lag. In this case, the correct would be "if the forecaster uses lags 1, 24, 48 last_window must include the last 48 values of the series".

We will correct it! Thank you 😄

JavierEscobarOrtiz avatar Aug 08 '22 09:08 JavierEscobarOrtiz

Fixed it in version 0.5.0.

JoaquinAmatRodrigo avatar Sep 24 '22 09:09 JoaquinAmatRodrigo