Joannis Orlandos
Joannis Orlandos
What's the goal of this PR?
@0xTim sorry for missing your message; I mean, what's the intention behind this new feature? To make it easier to work with `app.storage`? Or is there another goal?
Interesting use case. I think this should be supported nonetheless.
I think that's mostly up for debate / deferred to the end user implementation. Many people prefer not using MD5, but rather SHA1, or a modern standard like SHA2 (whichever...
@vzsg Multipart should in theory be streamable, but it's not currently supported. The caveat is that you'll need to consume the parts in order.
@gwynne I think the issue is that WebSocketKit doesn't start the upgrade on 'mount' I.E. `channelActive`, which we should. It does to _immediately_ after though.
@flowtoolz what client do you use to send this. Do you have example code for both sides? I think it's not a common usecase, as the upgrade starts immediately after...
Ping @gwynne
@wendellli99 it can't get reviewed yet, as this PR depends on the unmerged async streams PR. The PR is marked as merged, but was reverted