Idea of a new rule "Assignment statement rather than assignment in expression"

[nbauma109]

This new rule would be the equivalent of the one with increment/decrement inside expression. https://github.com/JnRouvignac/AutoRefactor/blob/master/plugin/src/main/java/org/autorefactor/jdt/internal/ui/fix/ObsoleteIncrementStatementRatherThanIncrementExpressionCleanUp.java

As you may already know, Sonar raises a warning when assignement is inside an expression.

Example of non-compliant code candidate for refactoring

if ((str = cont.substring(pos1, pos2)).isEmpty()) { 
  //...

Desired refactoring result would be the Sonar-compliant version

str = cont.substring(pos1, pos2);
if (str.isEmpty()) {
  //...

Let me know you thoughts on it.

Would it be complicated to do?

[Fabrice-TIERCELIN]

What is the difference with the existing rule No assignment in if condition (ObsoleteNoAssignmentInIfConditionCleanUp.java)?

[nbauma109]

Ah ok, I didn't notice that rule "No assignment in if condition (ObsoleteNoAssignmentInIfConditionCleanUp.java)" existed. So the idea would be to extend the principle to other expressions than if expressions, such as method invocations, array accesses,...