JiaKe

Results 54 comments of JiaKe

@mbasmanova @aditi-pandit Indeed, enabling stable sort may have an impact on performance, but in the current Gluten environment, we are facing issues with inconsistent results, as the results of the...

> > in the current Gluten environment, we are facing issues with inconsistent results > > Would you elaborate a bit on the use cases that are affected? Are you...

@Yuhta Reopen https://github.com/facebookincubator/velox/pull/8545 and refined the unit test to pass the code changes. Can you help to review again? Thanks.

> it seems the error is not as expected > > ``` > java.lang.IllegalStateException: Data not found at /tmp/tpcds-generated-30.0, try using command ` data-gen-only ` to generate it first. >...

@zhztheplayer The CI is passed. Please help to pick this [commit](https://github.com/oap-project/velox/commit/d90f777ed0d6d0148173e67e707b230dc5b9ccb1) into oap velox in next round rebase. Thanks.

`dense_rank ` already supported in velox https://github.com/facebookincubator/velox/pull/6289.

> @JkSelf Stable sort makes sense only if order of input rows for the sort is fixed. However, this is not the case. In the query above, inputs to sort...