Dimitris "Jimi" Charalampidis

No, just the one you provided.

In order to update the workflow we need to first update the projects node engine minimum requirement. To update the projects node engine we need to first update the `nodegit`...

Maybe we should ditch the `npm` upgrade step entirely.

`node` engine is tied to the version the `nodegit` uses.

Aren't we talking about `wpil workflow` here? The node version is `14.21.3`

> The `node` engine is [`>=16.14.2`](https://github.com/vscode-icons/vscode-icons/blob/master/package.json#L34), but you’re saying `nodegit` requires Node.js 14. That `node` engine is tied to the one `vscode` uses.

Btw, `wpil` stands for **w**iki **p**age **i**cons **l**ist.

> These are the steps of the [`wpil` workflow](https://github.com/vscode-icons/vscode-icons/pull/3432/files): > > * ✔️ Setup Node.js 14 > * ✔️ Update to npm 10 > * ✔️ Clone vscode-icons/vscode-icons > *...

Or does updating to npm@9 solves your issue?

> AFAIK the node engine field doesn’t mean anything for VSCode extensions, only the vscode engine does. For `vscode` yes it doesn't but for our project it does. `engines` should...