Dimitris "Jimi" Charalampidis

Results 92 comments of Dimitris "Jimi" Charalampidis

Can't seem to find the reasoning. Any links?

I did. The docs doesn't say the why.

That's no serious reason to migrate. I'm not saying that we shouldn't but I can't see any security or urgent reason.

`vscode API` is already asynchronous so you don't need `promisify`.

And since you are going to use `vscode API` those functions need to be moved to `VSCodeManager` class and all tests have to be changed. As I said... Easier said...

On another note, the switch to this API can only occur when our minimum supported `vscode` version reaches `v1.37`.

@xgdgsc Your linked issue has nothing to do with the use of the API or not.

The minimum support `vscode` version has now reached `v1.31.1`. We are getting closer to `v1.37`. We probably switch to it after July 2020.

@robertohuertasm needs to have a look at this. I suspect it's something similar to the `smart-component` thing.