Jim Brunner comments

Repositories
Issues
Comments

Results 23 comments of


                                            Jim Brunner

heap-buffer-overflow in valkey-check-aof

I'm certainly not an expert in this area. But everything I'm reading indicates that YES, ASAN will intercept calls to `strncmp`. It looks like this file is defining the interceptors:...

Adding support for sharing memory between the module and the engine

> @JimB123 since Ran asked for another pair of eyes, PTAL. Also Ran, please approve if you are happy with the PR. Ack. Reviewing.

Adding support for sharing memory between the module and the engine

> IMO the open issues + correctness + trivial code refactor can be completed in order to merge it. > We can consider followup in a different PR about the...