Jimmy
Jimmy
Hey Chris, can you please add a few UTs to demonstrate how your pr improves the leveldb? I am reviewing your code, but dont really clear how and where the...
Will check part 2 as well then, but please avoid doing this, cause it makes a single pr not reviewable.
@superboyiii can you please rake a look at this pr and do some tests on it?
no longer needed, close to clean up the pr list, such that we can focus on active prs.
need explaination why adding these uts, to make sure these uts are not duplicate
``` /_/tests/Neo.UnitTests/SmartContract/Native/UT_RoleManagement.cs(75): error test failed: TestSetAndGet (58ms): Assert.AreEqual failed. Expected:. Actual:. [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj] /_/tests/Neo.UnitTests/SmartContract/Native/UT_RoleManagement.cs(75): error test failed: Stack Trace: [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj] /_/tests/Neo.UnitTests/SmartContract/Native/UT_RoleManagement.cs(75): error test failed: at Neo.UnitTests.SmartContract.Native.UT_RoleManagement.TestSetAndGet() in /_/tests/Neo.UnitTests/SmartContract/Native/UT_RoleManagement.cs:line 75 [/home/runner/work/neo/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj] /_/tests/Neo.UnitTests/SmartContract/Native/UT_RoleManagement.cs(75):...
> What's new here except duplicating #3510 and #3517? We need something real, not ChatGPT. chatgpt polished, yes. major content from 3510 and 3517, yes. something real? not sure. are...
@roman-khimov from the very begining until the last core meeting, ive kept saying i admire your ability of writing fancy documents, i still do. i can never make my idea...
well, truth is i wrote everything, then use it to rephrase the grammer issue, low quality in others may cause of gpt itself, but low quality i wouls say its...
but, on the other hand, if anypne would love to take my place and rewrite all the proposal in a respecting way, i appreciate that. cause i am not good...