outline-server icon indicating copy to clipboard operation
outline-server copied to clipboard
verified publisher icon Jigsaw-Code

Share definitions between workspaces

Open alalamav opened this issue 5 years ago • 1 comments

  • Leverages yarn workspaces to share type definitions, reducing duplicate interfaces.
    • shadowbox depends on outline-metrics-server for the metrics report interfaces.
    • outline-manager depends on shadowbox for (some) API definitions.
  • Stops installing npm dependencies in the outline-manager web app, which should be safe since we no longer use require() in the renderer process.

alalamav avatar May 05 '20 21:05 alalamav

Thanks for the review. I have address all your comments related to importing modules directly - didn't know it was possible.

alalamav avatar May 06 '20 00:05 alalamav