outline-server icon indicating copy to clipboard operation
outline-server copied to clipboard

Refactor TOS logic

Open fortuna opened this issue 6 years ago • 3 comments

This moves application logic out of the ui components. Also, stops using the hidden approach and uses a dialog instead, which is a more maintainable pattern.

fortuna avatar Jun 07 '19 17:06 fortuna

I think the dialog would look better with some more spacing between the image and the text. Also, the unit tests are failing, presumably due to the refactor?

alalamav avatar Jun 07 '19 21:06 alalamav

Ugh, I found out what the problem is: the tests don't define localStorage. I'll need to figure out what to do after I'm back from RightsCon.

fortuna avatar Jun 07 '19 23:06 fortuna

@fortuna do you still want to do this?

JonathanDCohen avatar Oct 22 '19 22:10 JonathanDCohen