Multiple issues with the build

[fortuna]

Let's fix these issues in order to unblock future releases and prevent further breakage.

Manager

Signing of the Windows Server Manager is broken

Command, from macOS:

npm run action server_manager/electron_app/package windows

Packaging of the Manager on Linux and macOS are fine, though it takes a really long time for macOS.

Client

Misplaced environment.json on Client build

The packaging of the Cordova Clients is creating www/environment.json in the repo root. Command from macOS:

npm run action client/src/cordova/build macos

The www/ directory does not even exist. This is clearly wrong, so packaged apps will misbehave. Probably a missed migration from https://github.com/Jigsaw-Code/outline-apps/pull/1945.

Misplaced client icons

I got this when building macOS:

Can we make the build fail in case of missing images?

macOS Client build takes forever

That's because we build for ios, iossimulator, maccatalyst and macos. The builds don't seem to get faster, so it's probably not incremental. We need to investigate how to make it faster.

Both

No packaging test

We should run the packaging step on CI if possible to detect packaging breakage.

[daniellacosse]

I think we'd need an internal CI step to test the packaging, right? Because it contains secrets.

[sbruens]

There are some issues with the manager build and tests as well. Fixing them in #1971.