outline-apps icon indicating copy to clipboard operation
outline-apps copied to clipboard

Issue Invites With Domain Name Instead of IP Address

Open yakovmanshin opened this issue 6 years ago • 7 comments

Outline Manager currently accepts configuration strings that contain a domain name instead of the server’s IP address in apiUrl. However, invites issued by the app still contain the IP address.

It would be great if invites issued by Outline Manager that is configured with a domain name referenced the same domain name instead of the server’s IP address.

Right now, it is possible to manually replace IP addresses with domain names in invites, but less tech-savvy users may get stuck on this step.

Example

Outline Manager accepts this: { "apiUrl": "https://node1.outline.example.com:1234/V0exXlX58SvhD_6kmCME3A", "certSha256": "B06368232C4769A6D14962F76F0BEB4A75DFFAC1FE7EB5230E4D9824AB0BFCA3" }

Still, invites created with Outline Manager look like this: ss://[email protected]:1234/?outline=1

It would be nice if invites looked like this: ss://1234abcd1234abcd1234abcd1234abcd1234abcd1234abc=@node1.outline.example.com:1234/?outline=1

yakovmanshin avatar May 04 '18 14:05 yakovmanshin

@yakovmanshin Thanks for the feedback! I'm glad you were able to get connected. Yes, it would be nice if the manager offered to use a domain name rather than IP. This is a feature we'll be looking into.

trevj avatar May 14 '18 19:05 trevj

As hostname is written when access key is created, this hostname is injected trough an environment variable and that variable is, presumably, transpiled in the build step, I think that it will be necessary to read hostname from other source that do not require to rebuild Docker image.

I think it is related with this.

Correct me if I'm wrong but, ¿is it possible that, currently, if we put the domain instead the raw IP on the initial setup the keys will be generated with domain name?

sergiowalls avatar Apr 23 '19 23:04 sergiowalls

Having the hostname is a very good idea. One potential benefit of using the hostname is the ability to jump to new IP addresses, if necessary. So the VMs can move around. Can you think of any configuration problems associated with this?

thelonious89 avatar Apr 24 '19 00:04 thelonious89

Helo you solved the problem with the domain on oupline?

gasan005 avatar Jan 29 '20 11:01 gasan005

There's a hostname option in the Server Information tab that you can edit. That will be used in the access keys you generate.

fortuna avatar May 13 '21 15:05 fortuna

I've registered a domain in my instance and assigned it to my server, how can i set my outline manager to work with domain name? and the invation links with domain name as well ? i've tried your commands but manager gives me error like this, why ?

((Your Outline Server was installed correctly, but we are not able to connect to it. Most likely this is because your server's firewall rules are blocking incoming connections. Please review them and make sure to allow incoming TCP connections on ports ranging from 1024 to 65535.))

Navid-Atshani avatar Nov 04 '23 19:11 Navid-Atshani

@Navid-Atshani opened a new issue for your question: Jigsaw-Code/outline-apps#1854

maddyhof avatar Nov 06 '23 15:11 maddyhof