chore(client): move the client to its own subfolder

[daniellacosse]

I was able to successfully move the client into its own subfolder:

TODO:

• [x] should i move build into the root? or try to mess with ROOT_DIR?
• [x] basic documentation
• [x] move third_party into the root (need help from @jyyi1)
• [ ] unbreak it... again
  • [x] electron
  • [ ] windows (it can't find the env.nsh)
  • [ ] android working in the CI (dialer.Dial undefined??)
  • [x] maccatalyst working in the CI

[daniellacosse]

A number of tests are still failing, so I think there's still stuff to figure out.

Sorry I prematurely took this out of draft. Let me put it back into draft mode.

[daniellacosse]

@jyyi1 I've updated the SDK - didn't you say some naming changed? What should I fix

[jyyi1]

@jyyi1 I've updated the SDK - didn't you say some naming changed? What should I fix

Basically anytime you see an error: dialer.Dial undefined (type transport.StreamDialer has no field or method Dial), just rename the Dial in the source code to DialStream (if the error message mentions StreamDialer) or DialPacket (if the error message mentions PacketDialer).

[daniellacosse]

For the Windows build failure, we just need to specify the projectDir when calling electron-builder (currently it's D:\a\outline-apps\outline-apps, but it should be D:\a\outline-apps\outline-apps\client because env.nsh will be generated there), similar to what we did in manager.

I'm not really sure where it's looking for the env.nsh and the surrounding files here don't really give me a clue: https://github.com/Jigsaw-Code/outline-apps/blob/9229b6dbb20681a3a7d12dffcbfb8cb5bdc96f1d/client/src/electron/custom_install_steps.nsh#L19-L20

I've tried copying it to several directories and it still fails to find it. Any ideas?

[fortuna]

@daniellacosse can we perhaps only migrate Cordova in this PR so we can move forward quickly?

[daniellacosse]

@daniellacosse can we perhaps only migrate Cordova in this PR so we can move forward quickly?

Yes!! I asked in the chat if we were okay with that but I guess it got lost. I can try to make that work once I get back.