outline-apps icon indicating copy to clipboard operation
outline-apps copied to clipboard

fix(cordova/apple/macos): create new `NETunnelProviderManager` instances when moving to Catalyst

Open sbruens opened this issue 1 year ago • 1 comments

Internally, iOS and macOS use different techniques for identifying code. A macOS-style link in the provider configuration fails to find iOS-style providers. We track whether we need to do this with a version in the providerConfiguration.

sbruens avatar Jan 19 '24 17:01 sbruens

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (e8dcd79) 32% compared to head (8e790d3) 32%.

Files Patch % Lines
...ineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift 0% 75 Missing :warning:
...utlineTunnel/NETunnelProviderManager+Outline.swift 0% 29 Missing :warning:
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1822   +/-   ##
======================================
- Coverage      32%     32%   -1%     
======================================
  Files          45      46    +1     
  Lines        2609    2670   +61     
  Branches      337     337           
======================================
  Hits          859     859           
- Misses       1750    1811   +61     
Flag Coverage Δ
apple 13% <0%> (-2%) :arrow_down:
ios ?
maccatalyst 13% <0%> (-2%) :arrow_down:
macos 13% <0%> (-2%) :arrow_down:
unittests 32% <0%> (-1%) :arrow_down:
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 19 '24 17:01 codecov[bot]