Intra icon indicating copy to clipboard operation
Intra copied to clipboard

Remove some non-determinism

Open licaon-kter opened this issue 7 months ago • 6 comments

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/

We can fix the GO BUILDID and the different /tmp paths.

licaon-kter avatar May 27 '25 16:05 licaon-kter

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 27 '25 16:05 google-cla[bot]

Haha CLA, no, but you can take this as you please :wink:

licaon-kter avatar May 27 '25 16:05 licaon-kter

Thanks for the contribution. But unfortunately this PR won't make the app reproducible. Because to ensure a reproducible build, we need to use a fixed version of gomobile, but they only officially provide the latest 0.0.0 version. This means that even if we fix the BUILDID, the produced binary isn't guaranteed to be reproducible.

jyyi1 avatar May 27 '25 17:05 jyyi1

True, but I've tested this, and as the title says it's about "some" of it. :)

Could this be made perfect? I hope so, in the mean time, this PR improves things.

licaon-kter avatar May 27 '25 17:05 licaon-kter

As said, I won't submit to any CLA. :)

licaon-kter avatar May 27 '25 20:05 licaon-kter

... to ensure a reproducible build, we need to use a fixed version of gomobile, but they only officially provide ... 0.0.0 ...

Also, gomobile driven builds don't yet respect -trimpath, at least not from what we've observed (from build of our Intra fork).

  • https://github.com/golang/go/issues/40254

ignoramous avatar May 27 '25 21:05 ignoramous