yay asks whether to install syncdeps twice

[drws]

Affected Version

yay v12.0.4 - libalpm v13.0.2

Describe the bug

When a package needs sync (repo) dependencies, yay/pacman asks to confirm their installation. If user refuses, yay asks again.

Reproduction Steps

1. Run yay -Syu libva-headless (for example).
2. Refuse when yay/pacman asks to confirm syncdeps' installation.

Expected behavior

yay asks only once.

Output

$ yay -Syu libva-headless
:: Synchronizing package databases...
 core is up to date
 extra is up to date
 community is up to date
AUR Explicit (1): libva-headless-2.18.0-1
Sync Dependency (1): libdrm-2.4.115-1
:: PKGBUILD up to date, skipping download: libva-headless
  1 libva-headless                   (Build Files Exist)
==> Packages to cleanBuild?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> 
  1 libva-headless                   (Build Files Exist)
==> Diffs to show?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> 
  1 libva-headless                   (Build Files Exist)
==> PKGBUILDs to edit?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> 
==> Making package: libva-headless 2.18.0-1
==> Retrieving sources...
  -> Updating libva git repo...
==> Validating source files with sha256sums...
    libva ... Skipped
:: (1/1) Parsing SRCINFO: libva-headless
:: Synchronizing package databases...
 core is up to date
 extra is up to date
 community is up to date
resolving dependencies...
looking for conflicting packages...

Package (2)         New Version  Net Change  Download Size

extra/libpciaccess  0.17-1         0.06 MiB       0.02 MiB
extra/libdrm        2.4.115-1      1.18 MiB       0.32 MiB

Total Download Size:   0.34 MiB
Total Installed Size:  1.24 MiB

:: Proceed with installation? [Y/n] n
error: could not set install reason for package libdrm (could not find or read package)
 -> Failed to install layer, rolling up to next layer.error:error installing repo packages
:: Synchronizing package databases...
 core is up to date
 extra is up to date
 community is up to date
resolving dependencies...
looking for conflicting packages...

Package (2)         New Version  Net Change  Download Size

extra/libpciaccess  0.17-1         0.06 MiB       0.02 MiB
extra/libdrm        2.4.115-1      1.18 MiB       0.32 MiB

Total Download Size:   0.34 MiB
Total Installed Size:  1.24 MiB

:: Proceed with installation? [Y/n] n
error: could not set install reason for package libdrm (could not find or read package)
 -> error installing repo packages
error installing repo packages

If the output is closely inspected, more issues can be seen:

• #2166.
• #2167
• error installing repo packages is printed twice in the end even though there wasn't really any error. I think this should go away by itself when all three issues are solved. Mentioning it just in case.