newengine ask for additional package install information compared to previous engine

[Porkepix]

Affected Version

yay v11.3.1.r116.g4e0a5c8 - libalpm v13.0.2

Describe the bug

With previous engine, every validation was done before any build step, now it asks for additional confirmation post-build by only toggling the new engine.

Reproduction Steps

1. Toggle the new engine with yay-git
2. Update an AUR/devel package
3. Notice the new confirmation as compared to before.

Expected behavior

I expected it to behave as before. But this also might be a choice. I had a single update to do, so I don't know either if it builds every AUR update and asks at the end, or ask confirmation after every build to install it (previous behavior, iirc, was to build one, install it, build the next, install it and so on).

[Jguer]

Hey @Porkepix, the new engine only uses "batch install", meaning it will build all AUR packages and then installs them in one go.

Notice the new confirmation as compared to before.

Can you clarify which new confirmation you're seeing?

[Porkepix]

Hey @Porkepix, the new engine only uses "batch install", meaning it will build all AUR packages and then installs them in one go.

Notice the new confirmation as compared to before.

Can you clarify which new confirmation you're seeing?

That's simply the standard pacman confirmation of installation, like:

==> Finished making: bottom-git 0.8.1.1669.g449d7356-1 (mer. 22 févr. 2023 08:24:35)

==> Cleaning up...
loading packages...
resolving dependencies...
looking for conflicting packages...

Packages (1) bottom-git-0.8.1.1669.g449d7356-1

Total Installed Size:  3.84 MiB
Net Upgrade Size:      0.00 MiB

:: Proceed with installation? [Y/n]

So I'm guessing that before it used to tell pacman to always say yes in such situations, or simply imputing enter as yes is the default choice (and as compared to other programs, -y have a different meaning here, and I didn't see anything such as a --yes in the manpage).

EDIT: But some of these stages are maybe intended, such as Sync Explicit (2) after selecting which packages to update, for example. which I believe wasn't here.

[Jguer]

Hey @Porkepix have you had the chance to experiment with

{
  "doubleconfirm": false
}

[Porkepix]

Didn't knew this had to be tested; now I did. Old behavior: a single confirmation after building AUR packages. New behavior with this option to true (default): ask a confirmation for official packages first, then build the AUR packages and ask confirmation again to install AUR packages after they were built New behavior with this option to false: no confirmation at all, neither for official packages nor for AUR ones after they're built. Dunno if that's the wished behavior, default or not, but in the current state it'd rather be named "installconfirmation" than "doubleconfirm": here the name let the user expect to still have one confirmation.

[Porkepix]

@Jguer Also note that this configuration value, that I kept set for now while waiting to know if some more input was expected from me, also have this side-effect of breaking updates in case of manual intervention for replacement needed, eg.:

looking for conflicting packages...
:: libgedit-amtk and amtk are in conflict. Remove amtk? [y/N]
error: unresolvable package conflicts detected
error: failed to prepare transaction (conflicting dependencies)
:: libgedit-amtk and amtk are in conflict
 -> error installing repo packages

I guess this should be considered as an issue in itself and reported elsewhere?