switcher icon indicating copy to clipboard operation
switcher copied to clipboard

Background change doesn't always happen

Open lukors opened this issue 3 years ago • 6 comments

If the style is changed by the schedule it doesn't always trigger the background change.

See this video to see what happens:

https://user-images.githubusercontent.com/1719884/146068086-fe66ae30-77d2-4557-adc3-bdc70953bf13.mp4

Unfortunately, the app does not generate any log messages.

lukors avatar Dec 14 '21 19:12 lukors

Mmm, Thanks for test it! I'll be researching a little bit about how does the scheduler work. Depending on how it works it may or may not be misbehavior of the app.

JeysonFlores avatar Dec 15 '21 22:12 JeysonFlores

I have good and bad news

JeysonFlores avatar Dec 16 '21 03:12 JeysonFlores

https://user-images.githubusercontent.com/68255757/146304930-daaa8623-a426-4a7b-a15d-bc75f1d879a1.mp4

Tip: fondo.png (amogus wallpaper) - b.jpg (pink wallpaper) If you see from the 0:14 the log says that the pink wallpaper was set, but the amogus wallpaper was still there. Also if you see at the 0:36 it looks how the pink wallpaper was set by half a second and then the amogus wallpaper was set again..... I think this is due to the contractor. If you see the logs whenever that bug appears, the log says the right wallpaper was set. I looked at the code of the Desktop Plug and it seems it uses other method for changing wallpapers (after all it's installed in a system-level, so the fact that this app must be packaged into flatpak means that I cannot do certain things.

JeysonFlores avatar Dec 16 '21 03:12 JeysonFlores

Ok, after debugging the wallpaper setting thing, it seems the code I wrote works fine. The console throws the message about the signal being triggered, the correct mode changed, it also has no errors on finding the wallpaper nor setting it up. I think I'll delegate this error to the contractor provided by the elementary team to interact with the wallpaper set of the desktop.

JeysonFlores avatar Dec 16 '21 20:12 JeysonFlores

Screenshot from 2021-12-21 10 37 46 I didn't have run on startup selected but launching switcher didn't fix the wallpaper. Maybe this can help reproduce?

ChildishGiant avatar Dec 21 '21 10:12 ChildishGiant

Well there are good and bad news about this issue. The good news: Probably this issue will be fixed The bad news: It might take a while.

In the submission request Danielle told me that using the contractor to change wallpapers is OK, but there's available a Portal to change wallpapers. I'm still studying about D-Bus, but I hope soon I can start adapting the codebase to it.

JeysonFlores avatar Dec 21 '21 17:12 JeysonFlores