JettHu

Results 86 comments of JettHu

> There's a low chance this gets merged. If you look at the commit history, Comfy hardly ever merges pull requests that aren't bug fixes. I'm not complaining, this is...

I've implemented another tcd comfyui node. repo: https://github.com/JettHu/ComfyUI-TCD

@YanzuoLu I am preparing to submit a PR for comfyui to add tcd to the comfyui official scheduler.

Because the default KSampler(KSamplerAdvanced) lacks the eta parameter, the current implementation has to use SamplerCustom (otherwise the default 0.3 is used) to see if the author is willing to add...

> @JettHu Nice done, friend! We have tested it on our Hyper-SD and it works perfect!!! We will soon update it on our [HF page](https://huggingface.co/ByteDance/Hyper-SD). Thanks for your great job!...

> UPDATE: at the moment I am not sure how much of myself being impressed with TCD was based on TCD sampler / scheduler, or it was just TCD LoRA....

> official example: ![test](https://private-user-images.githubusercontent.com/121283862/331456560-b6c19569-b435-438b-9d6b-85220c918d12.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY5ODYxMzYsIm5iZiI6MTcxNjk4NTgzNiwicGF0aCI6Ii8xMjEyODM4NjIvMzMxNDU2NTYwLWI2YzE5NTY5LWI0MzUtNDM4Yi05ZDZiLTg1MjIwYzkxOGQxMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUyOVQxMjMwMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04MzgyZjFhNzdiM2YzY2Q5NjhjYjhkZGM5NGFjZGVjZjg4NmJlN2ZjYjI5MGE1ZmM3YmEzMDExNzUxYjMwYTc2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.o-LyWvl0VlnSyiZ9vND9zsMwpiKXuZM8W0WTfWfPW1k) > > this PR: ![image](https://private-user-images.githubusercontent.com/121283862/331456615-02990831-fed1-4a89-9e8b-41def1c603d7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY5ODYxMzYsIm5iZiI6MTcxNjk4NTgzNiwicGF0aCI6Ii8xMjEyODM4NjIvMzMxNDU2NjE1LTAyOTkwODMxLWZlZDEtNGE4OS05ZThiLTQxZGVmMWM2MDNkNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUyOVQxMjMwMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05YWY1YWI4NGIxMjI5M2NlZDczOGRiOTk3NDMzZmI5MTM4NjlhMWQwNTA0NjRhZGYzZWNhZGE3Y2IwNDc3NTExJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.NVnzhH2Bp1rmpwlPAUwXUqx12abcM5WN3eDZ3-My7gw) > > The quality of the images seems to be slightly worse than the official example Are the results of the...

By the way, my results and workflow. ![ComfyUI_temp_crlpb_00006_](https://github.com/comfyanonymous/ComfyUI/assets/35261585/06a54afe-a597-4c95-9185-599c164df398) [tcd_pr_workflow.json](https://github.com/comfyanonymous/ComfyUI/files/15484444/tcd_pr_workflow.json)

> Could you guys please look into that difference mentioned by @comfyanonymous (between original diffusers and ComfyUI implementation), and double-check if sampler part is implemented properly? > > UPDATE: at...

Tesla T4 8G VRAM, Driver Version: 515.65.01 CUDA Version: 11.7 Server is started with `--disable-cuda-malloc` ```bash # pip freeze | grep torch torch==2.1.1+cu118 torchsde==0.2.6 torchvision==0.16.1+cu118 # I've not install xformers...