Gitnuro icon indicating copy to clipboard operation
Gitnuro copied to clipboard

Pressing escape should close detail view

Open ProjectInfinity opened this issue 2 years ago • 2 comments

When clicking a file either in a commit or from unstaged files you have to press the X to close the file view, allowing the Escape key to close the detail view would allow keyboard driven users to navigate the app easier.

ProjectInfinity avatar Jun 02 '22 19:06 ProjectInfinity

I'm planning to do it for dialogs in the 1.0.0 but other components may have to wait a bit more, as there are other prioritary issues.

If the event handling is easy enough I may also implement it as I implement it for the dialogs but not sure.

JetpackDuba avatar Jun 02 '22 23:06 JetpackDuba

I'm keeping this open as there is a little bug: All the dialogs/windows that accept the ESC as an input will be closed, even if they are not in-front. Aside from that, closing the diff, blame, history and dialogs with escape has been implemented.

JetpackDuba avatar Jun 06 '22 13:06 JetpackDuba