Gitnuro icon indicating copy to clipboard operation
Gitnuro copied to clipboard

Support for custom certificates

Open long76 opened this issue 2 years ago • 9 comments

Describe the bug SSL error by self-signed certificate.

To Reproduce Steps to reproduce the behavior:

  1. clone project by git shell from server with self-signed cert
  2. add repo to gitnuro
  3. press pull button

Expected behavior pull sucessfull

Screenshots 2022-11-24_09-31-44

Desktop (please complete the following information):

  • OS: Kubuntu
  • Version 20.04

maybe possible add trusted store from store - in path /etc/ssl/certs/ca-certificates.crt

long76 avatar Nov 24 '22 06:11 long76

Thanks for the report!😃

I'm busy for a few weeks but I'll give some feedback ASAP.

JetpackDuba avatar Nov 24 '22 18:11 JetpackDuba

Sorry for getting back so late.

Did you use the JAR or the flatpak version?

JetpackDuba avatar May 06 '23 14:05 JetpackDuba

Sorry for getting back so late.

Did you use the JAR or the flatpak version?

Jar

long76 avatar May 06 '23 15:05 long76

Can you try importing the certificate using the keytool utility? As shown here https://stackoverflow.com/a/4326346/4907735

I've used this exact command in the past with Android Studio, I hope it works here too.

JetpackDuba avatar May 06 '23 16:05 JetpackDuba

Can you try importing the certificate using the keytool utility? As shown here https://stackoverflow.com/a/4326346/4907735

I've used this exact command in the past with Android Studio, I hope it works here too.

yes i know about it but maybe i can just put my certs in folder with jar and program add certs in trust store in runtime? just if i update jdk cacerts will be overrided

long76 avatar May 06 '23 20:05 long76

best sostion on this use ca-certificates-java package but i can't use it in portable jdk

long76 avatar May 06 '23 20:05 long76

Oke, I'll look again into it in the future as a new feature rather than a bug. I don't know much about certificates and such stuff, but it's probably feasible.

Thanks for your feedback!

JetpackDuba avatar May 10 '23 18:05 JetpackDuba

For more usabilty if was ssl error GitNuro may suggest user add repo url in exclude for checking certs. And was great if will be some dialog or smth else with list excluded url for check. I see similar behavour in Megit(too use Java) https://github.com/eclipsesource/megit

long76 avatar May 24 '23 07:05 long76

Thanks! I've added the suggestion as part of #30

JetpackDuba avatar May 26 '23 10:05 JetpackDuba