teamcity-unity-plugin icon indicating copy to clipboard operation
teamcity-unity-plugin copied to clipboard

Allow use of a configuration parameter for the Unity Version

Open fklingler opened this issue 5 years ago • 7 comments

Hello!

I'd want to use a teamcity Configuration Parameter to configure the Unity Version, so my team can easily swap the version used when running a build (notably using the "custom run" button).

Unfortunately, this doesn't seem to work, as my agent is shown as incompatible: image

It doesn't seem that the configuration parameter is interpreted before the unity version is tested for the agents

fklingler avatar Mar 12 '19 17:03 fklingler

@fklingler, at the moment TeamCity does not support parameters resolution in agent requirements: https://youtrack.jetbrains.com/issue/TW-5661

You could vote/watch for the mentioned issue.

dtretyakov avatar Mar 12 '19 23:03 dtretyakov

Thanks, I will do that!

FYI, this enhancement you suggested https://github.com/JetBrains/teamcity-unity-plugin/issues/19 would also allow me to do what I want! It's in fact how we did it previously with an old teamcity unity plugin.

fklingler avatar Mar 13 '19 09:03 fklingler

Is there anyway we can build the runner to work around this issue? I'm also facing it and for now i'm just disabling the requirement check on my fork and using that rather than the official plugin. (We rely heavily on metarunners with parameters)

ArtOfSettling avatar Mar 25 '19 03:03 ArtOfSettling

Without this feature, updating several build configs that are all based on a handful of different templates becomes monotonous and error-prone. With a parameterized field, its a simple, easily-enforceable change.

I've voted for the related TeamCity feature request as well.

AaronZurawski avatar Jul 08 '19 15:07 AaronZurawski

@dtretyakov i realize TC doesn't support parameter resolution in agent requirements, but is there a way to overcome this, for example, by re-working how this mechanism works (e.g: don't use agent requirements) ?

This is a really basic requirement (setting different Unity versions) and the fact it's not working makes it very difficult to work with this plugin.

tallior avatar Nov 10 '20 07:11 tallior

@NikolayPianikov maybe we could somehow overcome this issue?

dtretyakov avatar Nov 10 '20 08:11 dtretyakov

I have submitted a PR #54 that adds support for TeamCity to be managed as a TeamCity agent tool. This may provide a viable alternative to solve this issue.

AaronZurawski avatar Nov 10 '20 14:11 AaronZurawski

It seems like a bit irrelevant issue was mentioned here earlier. As I can see, TC does support property resolution in agent requirements since 2020.2 EAP3. Relevant links:

  • https://github.com/JetBrains/teamcity-unity-plugin/issues/51
  • https://youtrack.jetbrains.com/issue/TW-19877/Support-property-resolution-references-to-agent-parameters-in-agent-requirements

Please feel free to reopen this issue if you are still running into the described problem.

lesley29 avatar Jan 12 '23 12:01 lesley29