teamcity-docker-server icon indicating copy to clipboard operation
teamcity-docker-server copied to clipboard

Added Ubuntu Perforce package

Open AaronZurawski opened this issue 6 years ago • 1 comments

Added Perforce binary to Ubuntu Dockerfile. Its installed using the instructions supplied by Perforce, and done using os-release so that it will install the correct package regardless of any base image changes.

Doing so required an intermediary gnupg package that is only installed during the build and then removed immediately. I also took the liberty of cleaning the downloaded apt lists which reduces the overall image size, and is recommended in the Docker Best Practices. I also modified the existing RUN command to follow these practices as well, such as moving the install packages to new lines for better diffs and ordering them alphabetically. I also moved the AND operators to the front as its easier to see which lines are a new command versus an argument.

AaronZurawski avatar Jan 12 '19 16:01 AaronZurawski

This also resolves #24

AaronZurawski avatar Jan 14 '19 15:01 AaronZurawski