resharper-fsharp icon indicating copy to clipboard operation
resharper-fsharp copied to clipboard
verified publisher icon JetBrains

Missing record fields

Open nojaf opened this issue 3 years ago • 3 comments

Add record field to signature file

This is based on 311. I believe the quick fix could also work for DefinitionsInSigAndImplNotCompatibleFieldOrderDiffer, but I want to await feedback first.

nojaf avatar Sep 27 '22 09:09 nojaf

Update record field type

nojaf avatar Sep 30 '22 06:09 nojaf

@auduchinok ready for another review!

nojaf avatar Oct 03 '22 09:10 nojaf

@auduchinok the IFSharpElementFactory can behave very differently based on what treeNode called the .CreateElementFactory() function.

Would it make sense to have a different factory for signature nodes? It would be the caller's responsibility to create the right factory, but at the very least you would be somewhat more conscious on what is possible.

Another question in that regard is how relevant is is for new signature nodes to be created by a signature file parser? In general, when I want to add something to a signature file. How important is it that the new nodes were created by using the ParsedSigFile tree? As implementation and signature share some nodes, does it matter much for Rider?

nojaf avatar Oct 06 '22 09:10 nojaf