resharper-fsharp icon indicating copy to clipboard operation
resharper-fsharp copied to clipboard

Add binding.GetParametersGroups API [WIP]

Open DedSec256 opened this issue 2 years ago • 4 comments

DedSec256 avatar Aug 30 '22 19:08 DedSec256

@DedSec256 What's the state here?

auduchinok avatar Sep 26 '22 15:09 auduchinok

@auduchinok, I'll try to finish it soon

DedSec256 avatar Sep 26 '22 15:09 DedSec256

@DedSec256 What do you think about splitting getting the parameter nodes and getting their names into separate APIs? Maybe something like this:

IReadOnlyList<IReadOnlyList<ITreeNode>> GetParameterNodes(ITreeNode node) string GetParameterName(ITreeNode node)

The current API does two unrelated enough things and it doesn't seem right.

auduchinok avatar Sep 27 '22 14:09 auduchinok

A side note: we should try to build common interfaces that would remove this ITreeNode processing and use typed getters instead. That could be quite challenging due to different representations of parameters and may require us to change the tree structure, though.

auduchinok avatar Sep 27 '22 14:09 auduchinok