resharper-fsharp icon indicating copy to clipboard operation
resharper-fsharp copied to clipboard

Code cleanup for multiple files?

Open josh-degraw opened this issue 4 years ago • 1 comments

I'm trying to format a codebase via fantomas, and for some reason the command-line tool seems to break sometimes, but the built-in formatter in Rider doesn't seem to suffer from the same issues, even though as I understand it they are using mostly the same underlying code for formatting.

My question is whether or not this plugin should be able to be utilized via the Code Cleanup feature in Rider. It seems like it's not (at least in my environment), but I'm unsure if that's intended or not. If I use the Reformat Code action, it formats correctly and respects the .editorconfig settings, but nothing happens if I try to format multiple files, which is the reason why I'm wondering if that's currently supported with this plugin. I'll survive if that's not the case, but either way some documentation about the expected functionality would be greatly appreciated. I apologize if such documentation does exist and I just couldn't find it.

josh-degraw avatar Jan 28 '21 22:01 josh-degraw

@josh-degraw We use Fantomas for Reformat Code as well. It's likely either not wired into Code Cleanup action properly like it's done for Reformat Code, or there's some exception during the cleanup that prevents the formatting. I'll look into it.

auduchinok avatar Feb 08 '21 14:02 auduchinok

I cannot reproduce it in Rider 2023.1, 'Reformat and Cleanup Code' for multiple files works as expected. @josh-degraw, If you happen to see this again, please let us know.

DedSec256 avatar May 02 '23 21:05 DedSec256