requirements icon indicating copy to clipboard operation
requirements copied to clipboard

some txt file recognize as requirements.txt

Open iris-qq opened this issue 3 years ago • 7 comments

image

iris-qq avatar Feb 15 '22 06:02 iris-qq

This bug is produced by too wide pattern by default in plugin settings. @meanmail , consider removing *.txt from defaults to be analyzed as requirements files.

To manually solve this issue go to settings and delete *.txt pattern.

baterflyrity avatar Mar 14 '22 10:03 baterflyrity

yeah,i remove this pattern,its ok now image

iris-qq avatar Mar 14 '22 13:03 iris-qq

yeah,i remove this pattern,its ok now

Nice! Dont close this issue pls until author answer.

baterflyrity avatar Mar 14 '22 15:03 baterflyrity

I'd like to upvote this as a problem. The default certainly should not include *.txt

rkechols avatar Apr 22 '22 17:04 rkechols

Same problem here. Removing "*.txt" as recognized file type for this plugin is unfortunately only a temporary workaround: install an update and the association is back.

tomyy avatar Jan 09 '23 12:01 tomyy

Btw this issue can be easily fixed by removing *.txt from https://github.com/meanmail-dev/requirements/blob/7181bcb628831411406bda5e9707e1c9b0b3760e/src/main/resources/META-INF/plugin.xml#L21.

Nevertheless Im not almost sure and dont have build environment hence wont create any PR. Anyway @meanmail is welcome to do this and publish new version.

baterflyrity avatar Jan 09 '23 13:01 baterflyrity

This is a nice plugin, but this is a horrible default matching pattern. I have several .txt files in a project that were being hammered by PyCharm's error checking because of the default pattern match of *.txt. Is this not a trivial fix or is there a case to be made for assuming every text file should be error-checked as a source of requirements?

Franken151 avatar Feb 24 '23 01:02 Franken151