kotlin icon indicating copy to clipboard operation
kotlin copied to clipboard

KT-72838: [Gradle] Support websockets in webpack devServer proxy

Open broundee opened this issue 6 months ago • 4 comments

Fixes KT-72838

Add ws parameter to webpack devServer proxy DSL in gradle plugin so that it is passed through to the generated webpack config.

The parameter is not listed in the webpack docs, but it's described in the underlying library's docs here:

option.ws: true/false: if you want to proxy websockets

broundee avatar May 29 '25 00:05 broundee

@broundee Thank you so much for the contribution 🙏

JSMonk avatar Jun 01 '25 17:06 JSMonk

It would be good to have a unit or functional test (just to verify the output is correct, it doesn't need to be a full integration test).

adam-enko avatar Jul 10 '25 11:07 adam-enko

Added the test in 731ad6eee109321cb2f8de60950a9555adf458b5.

broundee avatar Jul 13 '25 23:07 broundee

@JSMonk @bashor btw in future I would like to require all public-facing KGP JS code has KDoc. I'll let this one slide because we (@ilgonmic @JSMonk and me) already started adding KDoc to this class, so we'll add KDoc for ws in that MR.

adam-enko avatar Jul 16 '25 15:07 adam-enko