kotlin
kotlin copied to clipboard
JetBrains
FE: don't lose annotations on Java primitive arrays
There are 10 failed tests.
LoadJava8TestGenerated$SourceJava$TypeUseAnnotations:
-
testBaseClassTypeArguments -
testClassTypeParameterBounds -
testMethodTypeParameterBounds -
testReturnType -
testValueArguments
The same in LoadJava8TestGenerated$CompiledJava$TypeUseAnnotations.
We have finally discussed this PR today. It's simple by itself and could be acceptable. However, it's quite clear that we have a breaking change here, and as I know from you, this breaking change has at least some impact. In this case it's not allowed to add this error without warning. So we propose to implement a warning in K1, instead of an error. K2 already has an error, and it's quite fine.
Done - the annotations will only enhance for warnings without the EnhanceNullabilityOfPrimitiveArrays language feature. Not sure about the version, so I've put 1.9 in - should it be the next one instead?
Done - the annotations will only enhance for warnings without the
EnhanceNullabilityOfPrimitiveArrayslanguage feature. Not sure about the version, so I've put 1.9 in - should it be the next one instead?
Yes, I'd say it should be the next version. However, it's not yet created, so I suggest to leave version 1.9 in your code as is. I will change the language feature version before merging.
@dzharkov approved this PR, so I will merge it this week.
@pyos Could you please fill the LC issue in KT-54521? I was told you know how to do it.