koog icon indicating copy to clipboard operation
koog copied to clipboard

Make agents-mcp support KMP targets

Open kpavlov opened this issue 4 months ago • 2 comments

Motivation and Context

To make McpTool cross-platform

Changes

  • Moved reusable implementations (e.g., McpToolRegistryProvider, McpTool) to commonMain.
  • Updated Gradle configurations to align with Multiplatform support.
  • Adjusted platform-specific implementations where necessary.
  • Improved test structure using shared test utilities.

Changes

  • Moved reusable implementations (e.g., McpToolRegistryProvider, McpTool) to commonMain.
  • Updated Gradle configurations to align with Multiplatform support.
  • Adjusted platform-specific implementations where necessary.
  • Improved test structure using shared test utilities.

Breaking Changes

  • McpToolRegistryProvider.defaultStdioTransport is JVM-only and has to be imported (import ai.koog.agents.mcp.defaultStdioTransport)

Type of the changes

  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [ ] Tests improvement
  • [x] Refactoring

Checklist

  • [ ] The pull request has a description of the proposed change
  • [ ] I read the Contributing Guidelines before opening the pull request
  • [ ] The pull request uses develop as the base branch
  • [ ] Tests for the changes have been added
  • [ ] All new and existing tests passed
Additional steps for pull requests adding a new feature
  • [ ] An issue describing the proposed change exists
  • [ ] The pull request includes a link to the issue
  • [ ] The change was discussed and approved in the issue
  • [ ] Docs have been added / updated

kpavlov avatar Sep 07 '25 14:09 kpavlov

Project compiles with Kotlin 2.2.0+

kpavlov avatar Sep 07 '25 14:09 kpavlov

Qodana for JVM

833 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 792
Missing KDoc for public API declaration 🔶 Warning 25
Vulnerable imported dependency 🔶 Warning 16
@@ Code coverage @@
+ 67% total lines covered
11273 lines analyzed, 7580 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

  • Or via our issue tracker: https://jb.gg/qodana-issue
  • Or share your feedback: https://jb.gg/qodana-discussions

github-actions[bot] avatar Sep 07 '25 14:09 github-actions[bot]

Qodana for JVM

870 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 825
Missing KDoc for public API declaration 🔶 Warning 24
Vulnerable imported dependency 🔶 Warning 21
@@ Code coverage @@
+ 67% total lines covered
11681 lines analyzed, 7922 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

  • Or via our issue tracker: https://jb.gg/qodana-issue
  • Or share your feedback: https://jb.gg/qodana-discussions

github-actions[bot] avatar Sep 08 '25 13:09 github-actions[bot]